Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of batch query can vary depending on order of completion #29

Closed
michaelgoin opened this issue Sep 22, 2020 · 4 comments
Closed

Naming of batch query can vary depending on order of completion #29

michaelgoin opened this issue Sep 22, 2020 · 4 comments
Labels
enhancement New feature or request risk: medium This change impacts senstive areas or has other traits that warrant more careful consideration. size: medium A few days sync2jira
Projects
Node.js Engineering Board

Comments

@michaelgoin
Copy link
Member

Summary

This is minor but seems like we may want consistency here. Finalizing naming decision may make this unnecessary but wanted captured.

In the plugin model, batched queries execute through the plugin events separately (but often back to back at various steps depending on what is executed). As such, we currently aggregate the names for the batch transaction (and base segment) name. This aggregation happens at the end (for a consistent location for all names) but the invocation of that ending event depends on which completes first. So the order of the queries in the name can vary.

We may not have a good way to make this consistent, for the various cases, in which case we can discuss further.
@michaelgoin michaelgoin added the enhancement New feature or request label Sep 22, 2020
@michaelgoin michaelgoin added this to To do in Initial Support via automation Sep 22, 2020
@michaelgoin michaelgoin removed this from To do in Initial Support Oct 9, 2020
@michaelgoin michaelgoin added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Jan 14, 2021
@rr0214 rr0214 moved this from Triage Needed: Unprioritized Features to To do: Features here are prioritized in Node.js Engineering Board Aug 4, 2021
@michaelgoin
Copy link
Member Author

size: medium

@michaelgoin michaelgoin added the risk: medium This change impacts senstive areas or has other traits that warrant more careful consideration. label Sep 1, 2021
@bizob2828 bizob2828 added the size: medium A few days label Oct 13, 2021
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-4443

@kmudduluru kmudduluru moved this from To do: Features here are prioritized to Triage Needed: Unprioritized Features in Node.js Engineering Board Feb 27, 2024
@workato-integration
Copy link

This issue won't be actioned.

Node.js Engineering Board automation moved this from Triage Needed: Unprioritized Features to Done: Issues recently completed May 7, 2024
@kmudduluru
Copy link

Closing this for now as not much traction on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request risk: medium This change impacts senstive areas or has other traits that warrant more careful consideration. size: medium A few days sync2jira
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@coreyarnold @bizob2828 @michaelgoin @kmudduluru