Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js 13.3.0 breaks versioned tests #115

Closed
jmartin4563 opened this issue Apr 7, 2023 · 1 comment · Fixed by #116
Closed

Next.js 13.3.0 breaks versioned tests #115

jmartin4563 opened this issue Apr 7, 2023 · 1 comment · Fixed by #116
Assignees
@jmartin4563
Labels
bug Something isn't working
Projects
Node.js Engineering Board

Comments

@jmartin4563
Copy link
Contributor

Description

It appears that the 13.3.0 release of Next.js changed the way startServer works with regards to its return value. Before, startServer would return a promise that resolved to the app itself. In this latest release, it now returns a promise that returns a shutdown method. This causes our versioned tests to fail, as the helpers were relying on the return value of app.

Additional context
@jmartin4563 jmartin4563 added bug Something isn't working needs-triage labels Apr 7, 2023
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-8002

@newrelic-node-agent-team newrelic-node-agent-team added this to Triage Needed: Unprioritized Features in Node.js Engineering Board Apr 7, 2023
@jmartin4563 jmartin4563 self-assigned this Apr 7, 2023
@jmartin4563 jmartin4563 mentioned this issue Apr 10, 2023
Merged
Node.js Engineering Board automation moved this from Triage Needed: Unprioritized Features to Done: Issues recently completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartin4563 jmartin4563

Labels
bug Something isn't working
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updated next server setup to handle 13.3.0 changes jmartin4563/newrelic-node-nextjs
1 participant
@jmartin4563