Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable infinite tracing at launch if distributed tracing is disabled #452

Closed
mfulb opened this issue May 16, 2022 · 0 comments · Fixed by #462
Closed

Disable infinite tracing at launch if distributed tracing is disabled #452

mfulb opened this issue May 16, 2022 · 0 comments · Fixed by #462
Assignees
Labels
bug Something isn't working

Comments

@mfulb
Copy link
Contributor

mfulb commented May 16, 2022

Currently if infinite tracing is enabled while distributed tracing (DT) is disabled the following warning message will be output:

warning: cannot create a span event when a segment ID cannot be generated; is distributed tracing enabled?

This message can be output multiple times which is not the desired solution.

The proposed solution would be to disable infinite tracing at start up if DT is disabled and output a warning message to this effect. The message would aid troubleshooting settings and would only appear once per agent launch.

The original message can be shifted to a DEBUG log level instead of WARN so it might further aid troubleshooting without impacting normal usage of the agent.

@mfulb mfulb added the bug Something isn't working label May 16, 2022
@mfulb mfulb self-assigned this Jun 9, 2022
@lavarou lavarou changed the title fix(agent): Disable infinite tracing at launch if distributed tracing is disabled Disable infinite tracing at launch if distributed tracing is disabled Jun 16, 2022
@mfulb mfulb closed this as completed Jun 22, 2022
@mfulb mfulb added this to Triage - tag + prioritize. in PHP/C Engineering Board via automation Jun 22, 2022
@mfulb mfulb moved this from Triage - tag + prioritize. to Review in PHP/C Engineering Board Jun 22, 2022
@mfulb mfulb moved this from Review to Done in PHP/C Engineering Board Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant