Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8] Internals Unit Test Updates #51

Closed
kneitinger opened this issue Dec 10, 2020 · 0 comments · Fixed by #70
Closed

[PHP 8] Internals Unit Test Updates #51

kneitinger opened this issue Dec 10, 2020 · 0 comments · Fixed by #70
Assignees
@Fahmy-Mohammed
Labels
enhancement New feature or request on hold This issue or pull request is necessary, but better suited for the future
Projects
PHP/C Engineering Board
Milestone
PHP 8 Support

Comments

@kneitinger
Copy link
Contributor

Description

#49 makes the necessary changes for the agent to compile with PHP 8 libs and headers, however it does not address the agent unit tests. For this ticket, ensure all unit tests pass after #49 is merged in main.
@kneitinger kneitinger added enhancement New feature or request on hold This issue or pull request is necessary, but better suited for the future labels Dec 10, 2020
@kneitinger kneitinger added this to the PHP 8 Support milestone Dec 10, 2020
@kneitinger kneitinger added this to Triage - tag + prioritize in PHP/C Engineering Board via automation Dec 10, 2020
@zsistla zsistla moved this from Triage - tag + prioritize to In Progress in PHP/C Engineering Board Dec 17, 2020
@Fahmy-Mohammed Fahmy-Mohammed self-assigned this Dec 21, 2020
@kneitinger kneitinger linked a pull request Dec 22, 2020 that will close this issue
PHP 8 curl Object Fixes #70
Merged
@kneitinger kneitinger mentioned this issue Dec 22, 2020
Merged
PHP/C Engineering Board automation moved this from In Progress to Done Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fahmy-Mohammed Fahmy-Mohammed

Labels
enhancement New feature or request on hold This issue or pull request is necessary, but better suited for the future
Projects
PHP/C Engineering Board
  
Done
Milestone
PHP 8 Support
Development

Successfully merging a pull request may close this issue.

PHP 8 curl Object Fixes
2 participants
@kneitinger @Fahmy-Mohammed