Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't the new-relic-admin support nonced CSP? #580

Closed
allen-munsch opened this issue Jul 7, 2022 · 15 comments · Fixed by #998
Closed

Why doesn't the new-relic-admin support nonced CSP? #580

allen-munsch opened this issue Jul 7, 2022 · 15 comments · Fixed by #998

Comments

@allen-munsch
Copy link

allen-munsch commented Jul 7, 2022

self.body, lambda: browser_agent_data, self.search_maximum

Seems weird that the default would be "'unsafe-inline'"?

Any suggestions?

Similar:

@aaroncameron-wk
Copy link

As linked above, this has been implemented in the Ruby agent so would appear to be fairly trivial to implement for the Python agent as well. As far as I've seen, the reasoning for not doing this so far hinges on an assumption that it would involve breaking compatibility with outdated browsers, although that's not necessarily true or even important to many people, as expressed by many over 6 years in this thread.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@allen-munsch
Copy link
Author

It's not stale?

@stale stale bot removed the stale label Sep 21, 2022
@stale
Copy link

stale bot commented Nov 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2022
@joshuata
Copy link

This should not be marked as stale as it is a security focused feature request

@stale stale bot removed the stale label Nov 23, 2022
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2023
@allen-munsch
Copy link
Author

+1

@stale stale bot removed the stale label Mar 20, 2023
@stale
Copy link

stale bot commented May 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 22, 2023
@allen-munsch
Copy link
Author

+1

@stale stale bot removed the stale label May 22, 2023
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2023
@joshuata
Copy link

This should still be open as it is a security issue. I am seriously considering dropping newrelic due to the lack of movement on this

@Ak-x
Copy link

Ak-x commented Aug 24, 2023

Hello @joshuata, we will get this effort scoped out on our teams end and determine when we can add this to our upcoming releases.

cc: @ak-war

@stale stale bot removed the stale label Aug 24, 2023
@allen-munsch
Copy link
Author

@Ak-x Thank you!

@jimleroyer
Copy link

Our team using NewRelic would really like support for this. We cannot use NewRelic on the front-end at the moment due to its lack of configuration options to align with our CSP and our requirement to use a nonce. I feel let down as other agent implementations support it except the Python one.

Hope you folks can include this one in! 🤞

@allen-munsch
Copy link
Author

@TimPansino Thank you! Happy Holidays. 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants