Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud GUIDS: Instrument AWS SDK's Seahorse #2497

Closed
fallwith opened this issue Mar 8, 2024 · 2 comments
Closed

Cloud GUIDS: Instrument AWS SDK's Seahorse #2497

fallwith opened this issue Mar 8, 2024 · 2 comments
Assignees
Labels
5 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter

Comments

@fallwith
Copy link
Contributor

fallwith commented Mar 8, 2024

With a primary focus on generating cloud guids (an arn in the case of AWS) and a secondary focus on providing metrics segments for AWS SDK client calls, we should instrument the Seahorse::Client::Base class provided by aws-sdk-core (limiting support to v3+).

As of the latest (February 2024) release, the "install everything, please" aws-sdk-resources gem declares 378 dependencies on other aws-sdk-* gems. Given that the client classes in these other gems all inherit from Seahorse, it makes sense to go after Seahorse first and fill in any gaps in coverage later.

@fallwith fallwith added estimate Issue needing estimation jan-mar qtr Possible FY Q4 candidate labels Mar 8, 2024
@workato-integration
Copy link

@fallwith fallwith self-assigned this Mar 8, 2024
@kford-newrelic kford-newrelic added apr-jun qtr Represents proposed work item for the Apr-Jun quarter 5 Story Point Estimate and removed jan-mar qtr Possible FY Q4 candidate estimate Issue needing estimation labels Mar 15, 2024
@kford-newrelic kford-newrelic assigned tannalynn and unassigned fallwith Apr 15, 2024
@tannalynn
Copy link
Contributor

After looking into it, instrumenting seahorse wouldn't give us the information we need, so we will have to instrument each gems clients individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter
Projects
Archived in project
Development

No branches or pull requests

3 participants