Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate watched gems list #2553

Open
hannahramadan opened this issue Apr 11, 2024 · 1 comment
Open

Automate watched gems list #2553

hannahramadan opened this issue Apr 11, 2024 · 1 comment

Comments

@hannahramadan
Copy link
Contributor

Currently, we manually include which gems we recieve slack notifications about when those libraries recieve updates. That list lives inside slack_notifications.yml. It would be nice to automate this list so that we are checking for all instrumented gems.

gem_notifier.rb can be updated to use our configuration file to grab the names of gems, which start with instrumentation.. Not all gems names match the name we used for configuaration, so there will be some edge cases. Maybe adding a new method like this to start:

  def self.instrumented_gems
    gems = NewRelic::Agent::Configuration::DEFAULTS.keys.select { |k| k.start_with?('instrumentation.') }
    gems = gems.map do |gem|
      gem.to_s.gsub!(/instrumentation./, '')
    end
  end
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant