Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with Rails 6.1.0-alpha #330

Closed
sedubois opened this issue Apr 17, 2020 · 4 comments
Closed

Deprecation warning with Rails 6.1.0-alpha #330

sedubois opened this issue Apr 17, 2020 · 4 comments
Labels
community To tag external issues and PRs submitted by the community

Comments

@sedubois
Copy link

DEPRECATION WARNING: [] is deprecated and will be removed from Rails 6.2 (Use configs_for) (called from block in <class:EnvironmentReport> at ~/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/newrelic_rpm-6.10.0.364/lib/new_relic/environment_report.rb:73)

Tested with rails master (revision 9c4171bae14db25f6c663c1f52b850ff684ba37d) and newrelic_rpm 6.10.0.364.

@rachelleahklein
Copy link

Thank you for bringing this to our attention, @sedubois. It will be good to have in mind when we are working on official Rails 6.1 support.

@sedubois
Copy link
Author

Hi @rachelleahklein, happy to help. I've proposed a fix in #331. Could you consider already fixing this deprecation for those of us who are already working with Rails 6.1 (whether it be to support its preparation or to benefit early from its features)?

@rachelleahklein
Copy link

Hi @sedubois, thank you for submitting a PR to fix this! We'll take a look, but I don't foresee any issue with including the fix in our next release. We appreciate your work!

@tannalynn
Copy link
Contributor

This has been fixed in our newest release, version 6.11.0.
Thank you!

@angelatan2 angelatan2 added the community To tag external issues and PRs submitted by the community label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants