Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on license/api key conversation #257

Closed
gfuller1 opened this issue Dec 7, 2020 · 4 comments
Closed

Follow up on license/api key conversation #257

gfuller1 opened this issue Dec 7, 2020 · 4 comments
Assignees
Labels
waiting On hold, waiting for a response from another team

Comments

@gfuller1
Copy link
Contributor

gfuller1 commented Dec 7, 2020

Context: The SDK currently sends up data using an insights insert api key via the Api-Key header. Since there are several types of keys, what the customer should use can be confusing for customers. We hope to have the logic of how to handle different keys on the backend.

For this story we want to clarify which keys (license, api, insert) should work and which shouldn't work as headers in our Otel SDK requests and which headers we should send the keys in. This should be a discussion between our team and the architects to determine what the current expectations are.

Test if our OTel SDK is up to par with the expectations or if we need to make changes to it.

@gfuller1 gfuller1 added this to Triage in Java Engineering Board via automation Dec 7, 2020
@gfuller1 gfuller1 moved this from Triage to To do in Java Engineering Board Dec 7, 2020
@gfuller1 gfuller1 added the jlink label Dec 8, 2020
@jack-berg jack-berg self-assigned this Jan 4, 2021
@jack-berg jack-berg added the waiting On hold, waiting for a response from another team label Jan 4, 2021
@jodeev jodeev added waiting On hold, waiting for a response from another team and removed jlink waiting On hold, waiting for a response from another team labels Jan 4, 2021
@kford-newrelic kford-newrelic moved this from To do to Triage in Java Engineering Board Feb 22, 2021
@rfelgent
Copy link

Hi @gfuller1,

can I somehow vote up for "license key" support ?

@XiXiaPdx
Copy link
Collaborator

Hi @rfelgent , the SDK accepts license keys now - https://github.com/newrelic/newrelic-telemetry-sdk-java/releases/tag/v0.12.0 😄 This is the revelant API in the PR to enable it.

You'll provide your license key in the same parameter that use to be for the Insights key. The API above informs the SDK to send the key with the appropriate header to New Relic so it is evaluated as a license key.

I'll try to update the docs very soon with a working example.

@XiXiaPdx
Copy link
Collaborator

This has been resolved as the sdk now accepts both Insights Insert Key and License Key #271

Java Engineering Board automation moved this from Triage to Done Mar 12, 2021
@rfelgent
Copy link

rfelgent commented Mar 12, 2021

@XiXiaPdx thank you very much for the update! The feature "support license key" was a deal breaker for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting On hold, waiting for a response from another team
Projects
Archived in project
Development

No branches or pull requests

5 participants