Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FunnelChart): Add nr1-funnel-component to community library #16

Open
tangollama opened this issue Jan 7, 2020 · 2 comments
Open

Comments

@tangollama
Copy link
Contributor

https://github.com/newrelic/nr1-funnel-component

@tangollama tangollama added the enhancement New feature or request label Jan 7, 2020
@tangollama tangollama added this to the Community Components v. 1 milestone Jan 7, 2020
@devfreddy devfreddy removed their assignment Jan 17, 2020
@devfreddy
Copy link
Contributor

Initially added here - 19b7df8

Needs redesigned and defined a bit.

@devfreddy
Copy link
Contributor

Current Form:

<Funnel
  accountId
  launcherUrlState
  height={575}
  width={200}
  funnel={ { event, measure }}
  steps={[{ label: '', nrqlWhere: '' }]}
  series={[ { label: '', nrqlWhere: '' }]}
  ></Funnel>

Proposed Changes:

  • Add query to match nr1 FunnelChart signature - thinking the options here would be if you provide query we ignore steps and series??? Need to understand what the nr1 does relative to this one.
  • Remove launcherUrlState and replace with a more generic timeRange attribute that must be an object with a shape of begin_time, duration, end_time
  • Keep height/width
  • Change funnel.event to funnel.eventType
  • Change funnel.measure to funnel.attribute - Can we go more generic with attribute or is a measure an aggregate function applied to an attribute over time?
<Funnel
  accountId={accountId}
  query={nrql}
  timeRange={{ begin_time, duration, end_time }}
  height={575}
  width={200}
  funnel={ { eventType, attribute }}
  steps={[{ label: '', nrqlWhere: '' }]}
  series={[ { label: '', nrqlWhere: '' }]}
>
</Funnel>

@tangollama tangollama removed this from the Community Components v. 1 milestone Jan 21, 2020
@devfreddy devfreddy changed the title Add nr1-funnel-component to community library feat(FunnelChart): add nr1-funnel-component to community library Jan 27, 2020
@devfreddy devfreddy changed the title feat(FunnelChart): add nr1-funnel-component to community library feat(FunnelChart): Add nr1-funnel-component to community library Jan 27, 2020
@jpvajda jpvajda added this to Feature Backlog in NR1 3rd Party Nerdpack Community Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants