Skip to content

Commit

Permalink
RUBY-1401 Re-enable aggressive_keepalive by default
Browse files Browse the repository at this point in the history
  • Loading branch information
benweint committed Nov 24, 2014
1 parent fe63ae6 commit e04d5ce
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/new_relic/agent/configuration/default_source.rb
Expand Up @@ -1097,7 +1097,7 @@ def self.convert_to_list(value)
:description => 'A dictionary of label names and values that will be applied to the data sent from this agent. May also be expressed as a semi-colon delimited string of colon-separated pairs (e.g. "Server:One;Data Center:Primary".'
},
:aggressive_keepalive => {
:default => false,
:default => true,
:public => false,
:type => Boolean,
:description => 'If true, attempt to keep the TCP connection to the collector alive between harvests.'
Expand Down
4 changes: 2 additions & 2 deletions test/new_relic/agent/new_relic_service_test.rb
Expand Up @@ -130,7 +130,7 @@ def test_requests_after_connection_failure_in_session_still_use_connection_cachi
end

assert_equal([:start, :request, :finish], conn0.calls)
assert_equal([:start, :request, :request, :request, :finish], conn1.calls)
assert_equal([:start, :request, :request, :request], conn1.calls)
assert_equal([], conn2.calls)
end

Expand All @@ -157,7 +157,7 @@ def test_repeated_connection_failures

assert_equal([:start, :request, :finish], conn0.calls)
assert_equal([:start, :request, :finish], conn1.calls)
assert_equal([:start, :request, :request, :finish], conn2.calls)
assert_equal([:start, :request, :request], conn2.calls)
end

def test_repeated_connection_failures_on_reconnect
Expand Down

0 comments on commit e04d5ce

Please sign in to comment.