Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms threshold reported blank when assigning zero to it #12

Closed
RubyLi0612 opened this issue Jul 7, 2017 · 4 comments · Fixed by #13
Closed

Terms threshold reported blank when assigning zero to it #12

RubyLi0612 opened this issue Jul 7, 2017 · 4 comments · Fixed by #13
Labels
bug Something isn't working upstream

Comments

@RubyLi0612
Copy link

RubyLi0612 commented Jul 7, 2017

Terraform Version

Terraform v0.9.11

Affected Resource(s)

newrelic_alert_condition

Terraform Configuration Files

# Configure the New Relic provider
provider "newrelic" {
  api_key = "${var.newrelic_api_key}"
}

resource "newrelic_alert_policy" "alert" {
  name = "Policy"
}

Expected Behavior

Assign threshold of the condition to 0 successfully.

Actual Behavior

Error outputed as: Terms threshold can't be blank
image

Steps to Reproduce

terraform apply

Important Factoids

According to the documentation for terraform newrelic_alert_condition, threshold can be set to 0:
image
Yet assigning it to "0", 0, "0.0" all trigger the error.

@grubernaut
Copy link
Contributor

Upstream bug, submitted issue for a fix.

@RubyLi0612
Copy link
Author

Hi. Thank you for fixing the issue. I tried the updated newest version of this provider (also included the newest paultyng/go-newrelic) by creating some NewRelic conditions. There were no more error reporting on this issue. However, when I get onto my NewRelic account to view them, I found that one APM BROWSER APPLICATION METRIC condition showed blank in the threshold box, which was set to "0" in terraform:
screen shot 2017-07-12 at 3 45 00 pm
screen shot 2017-07-12 at 3 44 49 pm

Yet another APM APPLICATION METRIC condition went fine. I'm guessing that there remains some issue for different types?

@grubernaut
Copy link
Contributor

Hey @RubyLi0612, sorry you're still having an issue.

The fix above was only for the threshold attribute inside the terms configuration.
Can you elaborate on what you mean by:

I'm guessing that there remains some issue for different types?

Thanks!

@RubyLi0612
Copy link
Author

Sorry for the confusion. I meant to say that the threshold attribute inside the terms configuration for a browser application metric condition I created seems not working. It is supposed to show 0 when I set 0 through terraform, but showed empty entry instead. However, apm application metric condition is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
2 participants