new relic widget_billboard (newrelic_one_dashboard) tresholds value 0 not set

[arnehaese]

Hi there,

Thank you for opening an issue. In order to better assist you with your issue, we kindly ask to follow the template format and instructions. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests only. General usage questions submitted as issues will be closed and redirected to New Relic's Explorers Hub https://discuss.newrelic.com/c/build-on-new-relic/developer-toolkit.

Please include the following with your bug report

⚠️ Important: Failure to include the following, such as omitting the Terraform configuration in question, may delay resolving the issue.

• [ v2.22.1] Your New Relic provider configuration (sensitive details redacted)
• A list of affected resources and/or data sources
• The configuration of the resources and/or data sources related to the bug report (i.e. from the list mentioned above)
• Description of the current behavior (the bug)
• Description of the expected behavior
• Any related log output

Terraform Version

Run terraform -v to show the version. If you are not running the latest version of Terraform, please upgrade because your issue may have already been fixed.
Terraform v0.15.1
newrelic/newrelic v2.22.1

Affected Resource(s)

Please list the resources as a list, for example:

• resource "newrelic_one_dashboard"

Terraform Configuration

Please include your provider configuration (sensitive details redacted) as well as the configuration of the resources and/or data sources related to the bug report.

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
widget_billboard {
      title = "Jenkins failed jobs"
      row = 7
      column = 11
      width         = 2
      height        = 3
      warning       = 0
      critical      = 1
      
      nrql_query {
        query       = "SELECT uniqueCount(jobName) FROM AppBuildEvent WHERE buildResult = 'FAILURE' SINCE 24 hours ago EXTRAPOLATE"
      }
    }

Actual Behavior

What actually happened?
When the dashboard is created, the treshold for warning is not enabled (empty) for the widget - if I manually set it to 0 in the edit gui of new relic it is saved as a 0 hence reporting my value of on jenkins job failing as warning in yellow as expected - the treshold for critical is set to 1 correctly.

Expected Behavior

What should have happened?
I expect the 0 value to be set for the warning treshold

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply

Debug Output

Please provider a link to a GitHub Gist containing the complete debug output: https://www.terraform.io/docs/internals/debugging.html. Please do NOT paste the debug output in the issue; just paste a link to the Gist.

Panic Output

If Terraform produced a panic, please provide a link to a GitHub Gist containing the output of the crash.log.

Important Factoids

Are there anything atypical about your accounts that we should know? For example: Running in EC2 Classic? Custom version of OpenStack? Tight ACLs?

References

Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

• fix(deps): update module github.com/golangci/golangci-lint to v1.37.1 (master) #1234

[kidk]

Thanks for reporting this @arnehaese

We'll work on getting this resolved.

[jthurman42]

This is most certainly an "unset vs no value" issue, probably here in newrelic-client-go. Would need to update Value to be a *float64 to determine set vs unset, or remove omitempty from the json tag. Since the Billboard reference to Threshold is a slice, removing the omitempty would suffice as the value within DashboardBillboardWidgetThresholdInput is required

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

[mbazhlekova]

Hey @arnehaese 👋 we released a fix to this bug with version 2.24.1