Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config struct for 1:1 config to project #12

Closed
zlesnr opened this issue Jul 8, 2020 · 1 comment
Closed

Refactor config struct for 1:1 config to project #12

zlesnr opened this issue Jul 8, 2020 · 1 comment

Comments

@zlesnr
Copy link
Contributor

zlesnr commented Jul 8, 2020

Objective

Currently, the tutone generate.yml configuration is meant to be run 1:1 per package. After some deliberation, it seems like having a single config file for a given project might make more sense as we look to increase the scope of what tutone is doing.

One example proposal here is to leverage something like this:

packages:
  - name: alerts
    path: pkg/alerts
    types:
      - name: AlertsMutingRuleConditionInput
      - name: AlertsMutingRuleInput
      - name: AlertsPoliciesSearchCriteriaInput
      - name: AlertsPoliciesSearchResultSet
      - name: AlertsPolicy
      - name: AlertsPolicyInput
      - name: AlertsPolicyUpdateInput
      - name: AlertsNrqlConditionTermsOperator

Note that we have a series of packages (very go centric) where we can specify the name, and a path, and a list of types that we should filter down to. Then we can update the one configuration file to manage all the packages for a given project.

The above does not have to be the final solution, but removing the need to have a config per package makes some amount of sense here.

@zlesnr zlesnr added the size:M Medium label Jul 9, 2020
@zlesnr zlesnr added this to the Code Generator v1 milestone Jul 9, 2020
@sanderblue sanderblue self-assigned this Jul 9, 2020
@sanderblue sanderblue moved this from To do to In progress in NR1 Developer Toolkit Community Jul 9, 2020
@zlesnr zlesnr moved this from In progress to Review completed in NR1 Developer Toolkit Community Jul 14, 2020
@zlesnr zlesnr moved this from Review completed to Done in NR1 Developer Toolkit Community Jul 16, 2020
@zlesnr
Copy link
Contributor Author

zlesnr commented Jul 16, 2020

I believe this is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M Medium
Projects
No open projects
Development

No branches or pull requests

2 participants