Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black boundaries in some cases of Shiny dataset #49

Closed
Totoro97 opened this issue Feb 26, 2022 · 2 comments
Closed

Black boundaries in some cases of Shiny dataset #49

Totoro97 opened this issue Feb 26, 2022 · 2 comments

Comments

@Totoro97
Copy link

Hi, thanks for your great work!

I found there are some black lines in the boundaries of some images, in the Shiny dataset (for example, CD):

image

After I resize the image to the target width (1008), the black line still exists:

image

Could you help figure out the reason behind this issue? I would like to know if I should remove the boundary pixels during training (and also in testing).

Thank you very much!

@pureexe
Copy link
Contributor

pureexe commented Feb 26, 2022

My guess is this black border comes from COLMAP's undistort procedure.

We didn't handle this problem. but I think it should be fine to mask the border out and specify this problem on your report I guess.

If you have a better method for undistort or want to use different padding instead of zero padding to remove the black border. We also provide an image in the images_distort directory.

@Totoro97
Copy link
Author

Totoro97 commented Mar 3, 2022

Got. Thanks very much!

@Totoro97 Totoro97 closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants