Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout_onepage_progress showing previous users shipping address #455

Closed
csdougliss opened this issue Mar 7, 2014 · 10 comments
Closed

Comments

@csdougliss
Copy link
Contributor

Not sure if this is related to turpentine or not, but I am testing checkout (no HTTPS) and some of my users who are testing it are seeing a previous users shipping address in the checkout progress block?

We are using an external module to remove the postage step, but I have disabled it for now (only in it's admin setting):

Clearandfizzy_Reducedcheckout

@mytuxedo
Copy link

mytuxedo commented Mar 7, 2014

Add checkout/ to your URL blacklist in turpentine’s settings.

@csdougliss
Copy link
Contributor Author

Thanks, can be closed now. I thought this might be an issue but checkout_onepage_progress is specifically set in turpentine_esi.xml to not be cached?

@mytuxedo
Copy link

mytuxedo commented Mar 7, 2014

Interesting actually, the admin panel is exclusively defined to not cache it, even though while I was testing the admin panel in a non secure environment, varnish was definitely caching it. Which is why I added the URL to the blacklist which solved the problem.

This perhaps could be an issue?

@aheadley
Copy link
Contributor

aheadley commented Mar 7, 2014

@craigcarnell Sounds like there is a bug causing the nocache flag to be ignored, will investigate.

@mytuxedo This is probably a different issue, as the admin panel is blacklisted with the same mechanic as the URL blacklist. Are you using a non-standard admin location (i.e. not /admin/)? If so, how did you set it?

@evensisftw
Copy link
Contributor

@aheadley sorry was on another github account, I am indeed, it's set in etc/local.xml via:

<admin>
    <routers>
      <adminhtml>
        <args>
          <frontName><![CDATA[store_admin]]></frontName>
        </args>
      </adminhtml>
    </routers>
 </admin>

@aheadley
Copy link
Contributor

aheadley commented Mar 7, 2014

@evensisftw Ok, can you run this script from your Magento root directory and paste the output here?

<?php

define('MAGENTO_ROOT', getcwd());
include_once 'app/Mage.php';

var_dump( array(
    Mage::getStoreConfig( 'admin/url/use_custom_path' ),
    Mage::getStoreConfig( 'admin/url/custom_path' ),
    Mage::getConfig()->getNode( 'admin/routers/adminhtml/args/frontName' ),
) );

EDIT: Updated script with an extra line.

@evensisftw
Copy link
Contributor

array (size=3)
  0 => string '0' (length=1)
  1 => null
  2 => 
    object(Mage_Core_Model_Config_Element)[140]
      string 'store_admin' (length=11)

@aheadley
Copy link
Contributor

aheadley commented Mar 7, 2014

Very strange, store_admin should have been included in the URL blacklist then. Can you put your VCL in a gist and link it here?

@csdougliss
Copy link
Contributor Author

FYI I installed a self signed certificate and used HTTPS and it was still caching the block. Appreciate your effort. Thanks!

@sprankhub
Copy link
Contributor

I just had exactly the same issue on Magento 1.9.2.4 with Turpentine 0.7.2. Although adding checkout to the blacklist works, I think this should work out of the box. Would it make sense to populate the following URLs to the blacklist by default?

cron\.php
customer
checkout
paypal/ipn
paypal/standard/success
paypal/express/return
paypal/express/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants