feat: add sync function, return string, add describe option, remove cli #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16. Fixes #17.
Closes #15.
Complete library overhaul!
BREAKING CHANGE: Drops support for Next<6 and Node<8 (now using
async/await), changes return value from object to string (to be more compatible withgenerateBuildId), removes hacky file overwriting and thus the CLI (file overwriting is no longer necessary for modern versions of Next).Also adds a synchronous version via the new
syncfunction.Also adds a new
describeboolean option to use the output ofgit describe --tagsrather thangit rev-parse HEAD.See README for further details.
Optimized to read from git repo files instead of executing a
gitbinary, when possible.Tests and dev dependencies were updated accordingly.