Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate matplotlib dependence in diomira_test #37

Closed
jjgomezcadenas opened this issue Jan 6, 2017 · 2 comments
Closed

Investigate matplotlib dependence in diomira_test #37

jjgomezcadenas opened this issue Jan 6, 2017 · 2 comments
Assignees
@jjgomezcadenas

Comments

@jjgomezcadenas
Copy link
Collaborator

No description provided.

@jjgomezcadenas jjgomezcadenas self-assigned this Jan 6, 2017
@jjgomezcadenas
Copy link
Collaborator Author

Tests in diomira_test.py should not need to import matplotlib but apparently they do. Investigate

@jjgomezcadenas
Copy link
Collaborator Author

The reason is as follows: diomira_test.py tests the Diomira class itself, which in turn has a couple of methods to plot waveforms and depends therefore of matplotlib. The dependence, thus, is justified.

gonzaponte pushed a commit to gonzaponte/IC that referenced this issue Jan 26, 2017
@jjgomezcadenas
Merge pull request next-exp#37 from gonzaponte/ANASTASIA
cdee0e1 
ANASTASIA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjgomezcadenas jjgomezcadenas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjgomezcadenas