Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the configuration file #20

Closed
2 of 3 tasks
jiangtj opened this issue Jun 4, 2020 · 4 comments
Closed
2 of 3 tasks

Verify the configuration file #20

jiangtj opened this issue Jun 4, 2020 · 4 comments
Labels
Feature Request New feature or request Hexo

Comments

@jiangtj
Copy link

jiangtj commented Jun 4, 2020

Issue Checklist

  • I am using the latest version of NexT.
  • I have read the relevant documents of Hexo and NexT.
  • I have reviewed the latest Roadmap on GitHub and searched for current issues, which does not help me.

Expected behavior

Verify the configuration file of the theme, when our configuration changes, or the user fills in the wrong content, wecan remind the user to modify.

I try to use ajv check

yarn add hexo-theme-cake
# modify `theme` to `cake`
# exec check. see impl: https://github.com/jiangtj/hexo-theme-cake/blob/master/lib/console/check.js
hexo check

But the problem is that we need to maintain a huge json-schema. Even the compressed next theme (cake), config file line about 140. The schema has 276 lines. schema.json. The schema has 160 lines. schema.yml.

Do you think? @stevenjoezhang

Example

When I fill in a wrong value

image

@jiangtj jiangtj added the Feature Request New feature or request label Jun 4, 2020
@welcome
Copy link

welcome bot commented Jun 4, 2020

Thanks for opening this issue, maintainers will get back to you as soon as possible!

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label Question to this issue, with a confidence of 0.78. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stevenjoezhang
Copy link
Member

Superseded by hexojs/hexo#4580

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
@stevenjoezhang stevenjoezhang closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request New feature or request Hexo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants