Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeblock highlight does not work #29

Closed
3 tasks done
mans0n opened this issue Jun 13, 2020 · 8 comments
Closed
3 tasks done

codeblock highlight does not work #29

mans0n opened this issue Jun 13, 2020 · 8 comments
Labels
Bug Something isn't working Solved
Milestone

Comments

@mans0n
Copy link

mans0n commented Jun 13, 2020

Please follow this Issue template to provide relevant information, such as source code repositories, blog links, and screenshots, which will help us investigate.
请按照此 Issue 模版提供相关信息,例如源码仓库、博客链接和屏幕截图,这将有助于我们进行调查。

Issue Checklist

  • I am using the latest version of NexT.
  • I have read the relevant documents of Hexo and NexT.
  • I have reviewed the latest Roadmap on GitHub and searched for current issues, which does not help me.

Expected behavior

hightlight should work.
Screenshot_2020-06-13 Hexo

Actual behavior

hightlight does not work.
Screenshot_2020-06-13 Hexo(1)

Steps to reproduce the behavior

I ran this on Arch Linux.

sudo npm install -g hexo-cli
mkdir hexo && cd hexo
hexo init
git clone https://github.com/next-theme/hexo-theme-next themes/next
# set `theme: next` in hexo/_config.yml
hexo server

highlight.js version is 9.18.1.

If I change this line in scripts/events/lib/highlight.js
config.highlight.hljs = false;
to config.highlight.hljs = true;
then highlight works as expected.

It seems so evident to me, but I can upload my repo if requested.

Environment Information

Node.js and NPM Information

$ node -v && npm -v
v14.3.0
6.14.5

Package dependencies Information

$ npm ls --depth 0
hexo-site@0.0.0 /tmp/test
├── hexo@4.2.1
├── hexo-generator-archive@1.0.0
├── hexo-generator-category@1.0.0
├── hexo-generator-index@1.0.0
├── hexo-generator-tag@1.0.0
├── hexo-renderer-ejs@1.0.0
├── hexo-renderer-marked@2.0.0
├── hexo-renderer-stylus@1.1.0
└── hexo-server@1.0.0

Hexo Configuration

# Hexo Configuration
## Docs: https://hexo.io/docs/configuration.html
## Source: https://github.com/hexojs/hexo/

# Site
title: Hexo
subtitle: ''
description: ''
keywords:
author: John Doe
language: en
timezone: ''

# URL
## If your site is put in a subdirectory, set url as 'http://yoursite.com/child' and root as '/child/'
url: http://yoursite.com
root: /
permalink: :year/:month/:day/:title/
permalink_defaults:
pretty_urls:
  trailing_index: true # Set to false to remove trailing 'index.html' from permalinks
  trailing_html: true # Set to false to remove trailing '.html' from permalinks

# Directory
source_dir: source
public_dir: public
tag_dir: tags
archive_dir: archives
category_dir: categories
code_dir: downloads/code
i18n_dir: :lang
skip_render:

# Writing
new_post_name: :title.md # File name of new posts
default_layout: post
titlecase: false # Transform title into titlecase
external_link:
  enable: true # Open external links in new tab
  field: site # Apply to the whole site
  exclude: ''
filename_case: 0
render_drafts: false
post_asset_folder: false
relative_link: false
future: true
highlight:
  enable: true
  line_number: true
  auto_detect: false
  tab_replace: ''
  wrap: true
  hljs: false

# Home page setting
# path: Root path for your blogs index page. (default = '')
# per_page: Posts displayed per page. (0 = disable pagination)
# order_by: Posts order. (Order by date descending by default)
index_generator:
  path: ''
  per_page: 10
  order_by: -date

# Category & Tag
default_category: uncategorized
category_map:
tag_map:

# Metadata elements
## https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta
meta_generator: true

# Date / Time format
## Hexo uses Moment.js to parse and display date
## You can customize the date format as defined in
## http://momentjs.com/docs/#/displaying/format/
date_format: YYYY-MM-DD
time_format: HH:mm:ss
## Use post's date for updated date unless set in front-matter
use_date_for_updated: false

# Pagination
## Set per_page to 0 to disable pagination
per_page: 10
pagination_dir: page

# Include / Exclude file(s)
## include:/exclude: options only apply to the 'source/' folder
include:
exclude:
ignore:

# Extensions
## Plugins: https://hexo.io/plugins/
## Themes: https://hexo.io/themes/
theme: next

# Deployment
## Docs: https://hexo.io/docs/deployment.html
deploy:
  type: ''

NexT Configuration

DId not change default config.

Other Information

@mans0n mans0n added the Bug Something isn't working label Jun 13, 2020
@welcome
Copy link

welcome bot commented Jun 13, 2020

Thanks for opening this issue, maintainers will get back to you as soon as possible!

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label Bug to this issue, with a confidence of 0.65. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stevenjoezhang
Copy link
Member

Is it possible to provide the URL of your blog website? Thanks.

@mans0n
Copy link
Author

mans0n commented Jun 13, 2020

@mans0n
Copy link
Author

mans0n commented Jun 13, 2020

And added generated website: https://mans0n.github.io/index.html

@stevenjoezhang
Copy link
Member

Thanks for your feedback. This bug has been fixed in 3e8b35a

@mans0n
Copy link
Author

mans0n commented Jun 13, 2020

I confirm it works now without problem. Thanks for your quick response and fix!

@mans0n mans0n closed this as completed Jun 13, 2020
@stevenjoezhang stevenjoezhang added this to the 8.0.0-rc.4 milestone Jun 26, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Solved
Projects
None yet
Development

No branches or pull requests

2 participants