Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript definitions not published with library #243

Open
ehaynes99 opened this issue Jul 20, 2021 · 7 comments
Open

typescript definitions not published with library #243

ehaynes99 opened this issue Jul 20, 2021 · 7 comments

Comments

@ehaynes99
Copy link
Contributor

As there are already types, this simply needs an entry in package.json for "types" and to be added to "files"

@ts-thomas
Copy link
Contributor

Thanks for this hint. Could you make a pull request with these changes please? Thanks in advance.

@thaotx-zigvy
Copy link

bump

@ehaynes99
Copy link
Contributor Author

ehaynes99 commented Aug 3, 2021

It's linked above #244
I created it at the same time as the issue... Sorry I missed your comment here.

@josh18
Copy link

josh18 commented Aug 9, 2021

Note the types don't seem to match v7. Is the API mostly finalised for v7? I could try creating up to date types when I have time.

@RSWilli
Copy link

RSWilli commented Sep 13, 2021

the change done in #244 got somehow reverted and the current npm module is missing the types again

the index.d.ts is not published and typescript complains

@Losses
Copy link

Losses commented Sep 15, 2021

@jarrodek
Copy link

The https://www.npmjs.com/package/@types/flexsearch package does not work with ESM at all. The author suggests using the flexsearch/dist/module/* path but the @types/flexsearch package does not define these paths. Would be nice if this library would have own types included.

@ignatiusmb ignatiusmb mentioned this issue Oct 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants