Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/mikado.js line 850 typo error #12

Closed
moromindful opened this issue Oct 8, 2019 · 1 comment
Closed

src/mikado.js line 850 typo error #12

moromindful opened this issue Oct 8, 2019 · 1 comment

Comments

@moromindful
Copy link

Hi, in src/mikado.js on line 850 we have this.apply(tmp, item, view, x) and should have been this.apply(tmp, item, x, view). Right now you are passing the payload instead of the index.

I also provided a comment on your commit at the specified line.

I am now in the learning phase of mikado. And still have a bunch of things to test and see how they would fit best in my future projects. Anyway you did an amazing job creating mikado. Congrats!
@ts-thomas
Copy link
Collaborator

Very well seen. Fixed in 0.6.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ts-thomas @moromindful