Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiktok provider is missing url in token object / Second Attempt #10727

Closed
mwawrusch opened this issue Apr 25, 2024 · 1 comment
Closed

Tiktok provider is missing url in token object / Second Attempt #10727

mwawrusch opened this issue Apr 25, 2024 · 1 comment
Labels
bug Something isn't working invalid reproduction The issue did not have a detectable valid reproduction URL providers triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

Comments

@mwawrusch
Copy link

Provider type

Tiktok

Environment

System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 800.48 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.6.1 - ~/.nvm/versions/node/v20.6.1/bin/node
    npm: 9.8.1 - ~/.nvm/versions/node/v20.6.1/bin/npm
  Browsers:
    Chrome: 124.0.6367.78
    Edge: 124.0.2478.51
    Safari: 17.4.1```


### Reproduction URL

https://github.com/nextauthjs/next-auth

### Describe the issue

This is in reference to the prematurely closed issue https://github.com/nextauthjs/next-auth/issues/9790

The reason why the tiktok provider fails is because the tiktok provider needs the url set, but only the request is specified.

To fix this add the url like so at line 212 in tiktok.ts. Also notice the update within fetch, to be in line with other providers:


token: {
  url: 'https://open.tiktokapis.com/v2/oauth/token/',
  async request({ params, provider }) {
    const res = await fetch(provider.token?.url as URL, {
      method: "POST",

### How to reproduce

Include Tiktok as a provider and open your app.

### Expected behavior

It should not break the whole app.
@mwawrusch mwawrusch added bug Something isn't working providers triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Apr 25, 2024
@github-actions github-actions bot added the invalid reproduction The issue did not have a detectable valid reproduction URL label Apr 25, 2024
Copy link

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

  • If you did not provide a link or the link you provided is not valid, we will close the issue.
  • If you provide a link to a private repository, we will close the issue.
  • If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

  • If you did not provide a link, please open a new issue with a link to a reproduction.
  • If you provided a link to a private repository, please open a new issue with a link to a public repository.
  • If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

  • Remove any code that is not related to the issue. (pages, API Routes, components, etc.)
  • Remove any dependencies that are not related to the issue.
  • Remove any third-party service that would require us to sign up for an account to reproduce the issue.
  • Remove any environment variables that are not related to the issue.
  • Remove private packages that we do not have access to.
  • If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working invalid reproduction The issue did not have a detectable valid reproduction URL providers triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.
Projects
None yet
Development

No branches or pull requests

1 participant