Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): call generateVerificationToken async #1378

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 26, 2021

What:

When using the "email" provider, you can supply your own generateVerificationToken function to create a token of your liking.

Why:

Until now, it was not possible to do async operations inside this function.

How:

When generateVerificationToken is called, we simply put an await in front of it, so you can do any async task inside it.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

As mentioned by @iaincollins in #709 (comment), this is something we are supposed to support. So here you go 🙂

@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/HKPRKGdmBccQTwcYohtF2Wntz6gY
✅ Preview: https://next-auth-git-feature-async-generateverificationtok-08df4a.vercel.app

@github-actions github-actions bot added the core Refers to `@auth/core` label Feb 26, 2021
@vercel vercel bot temporarily deployed to Preview February 26, 2021 10:52 Inactive
@github-actions github-actions bot added the documentation Relates to documentation label Feb 26, 2021
@balazsorban44 balazsorban44 mentioned this pull request Feb 26, 2021
5 tasks
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balazsorban44 balazsorban44 merged commit d8d497c into main Feb 27, 2021
@balazsorban44 balazsorban44 deleted the feature/async-generateVerificationToken branch February 27, 2021 22:33
@github-actions
Copy link

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

🎉 This PR is included in version 4.1.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 4.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` documentation Relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants