Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add Mailchimp provider #1781

Merged

Conversation

michalbundyra
Copy link
Contributor

What: add new provider - Mailchimp

Why: working in project where I am using this provider, so it might be useful also for others

How:

Checklist:

  • Documentation
  • Tests N/A ?
  • Ready to be merged

@vercel
Copy link

vercel bot commented Apr 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/3H2s2aNuT3vboA9D5esL5d8U31u4
✅ Preview: https://next-auth-git-fork-michalbundyra-feat-mailchimp-pro-2671c5.vercel.app

@vercel vercel bot temporarily deployed to Preview April 20, 2021 09:00 Inactive
@github-actions github-actions bot added core Refers to `@auth/core` documentation Relates to documentation providers labels Apr 20, 2021
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love providers that implement OAuth in a way that "just works". 😁🎉 Nice PR, had a tiny comment, could you please check?

src/providers/mailchimp.js Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview April 20, 2021 15:30 Inactive
@balazsorban44
Copy link
Member

@michalbundyra my question stands about the scope. I wasn't curious if you can remove it but rather if it really works for you locally without providing any? I assumed that you would need something as basic as openid or something like that

@michalbundyra
Copy link
Contributor Author

@balazsorban44 in my code I have empty string for scope and it works, but I'll verify it again and will be back here. Thanks

@balazsorban44
Copy link
Member

balazsorban44 commented Apr 22, 2021

thanks! I really appreciate it! could you please revert the src/providers/index.js file change? that file is auto-generated now

@vercel vercel bot temporarily deployed to Preview April 23, 2021 07:51 Inactive
@michalbundyra
Copy link
Contributor Author

@balazsorban44 I checked again documentation and there is no single word about the scope. It works for me with empty scope tho.

It's now rebased, so merge conflicts are resolved. Thanks

@balazsorban44 balazsorban44 self-requested a review April 23, 2021 10:14
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@balazsorban44 balazsorban44 merged commit 49cb7e5 into nextauthjs:main Apr 23, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@michalbundyra michalbundyra deleted the feat/mailchimp-provider branch April 23, 2021 10:17
@github-actions
Copy link

🎉 This PR is included in version 4.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` documentation Relates to documentation providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants