Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): add clock tolerance #3071

Merged
merged 1 commit into from
Oct 31, 2021
Merged

fix(oauth): add clock tolerance #3071

merged 1 commit into from
Oct 31, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Oct 30, 2021

Some Providers like Azure B2C seem to be prone to clock issues.

#3032, #3067

With this PR, we introduce a tolerance of 10 seconds, which hopefully mitigates the problem, also for future cases.

@github-actions github-actions bot added the core Refers to `@auth/core` label Oct 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3071 (c293877) into beta (da991de) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #3071      +/-   ##
==========================================
- Coverage   13.71%   13.70%   -0.02%     
==========================================
  Files          86       86              
  Lines        1356     1357       +1     
  Branches      374      374              
==========================================
  Hits          186      186              
- Misses       1161     1162       +1     
  Partials        9        9              
Impacted Files Coverage Δ
src/core/lib/oauth/client.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da991de...c293877. Read the comment docs.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balazsorban44 balazsorban44 merged commit 4181988 into beta Oct 31, 2021
@balazsorban44 balazsorban44 deleted the fix/clock-tolerance branch October 31, 2021 13:57
@dg-eparizzi
Copy link

When are you guys releasing a new beta? This one is super important as it makes development against Azure AD B2C super annoying.

@balazsorban44
Copy link
Member Author

Whenever. 🙂 If it's super important, check out https://www.npmjs.com/package/patch-package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants