Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): set 42 default scope #3189

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

estarossa0
Copy link
Contributor

Reasoning 馃挕

Specifying the scope for the 42 provider as public, since it get defaulted to openid which is a invalid scope for 42 api.
Default has been set to public not an empty string which is mandatory for all 42 api apps.

Checklist 馃Б

- [ ] Documentation
- [ ] Tests

  • Ready to be merged

Affected issues 馃師

NONE

With no scope defined, it sets `openid` by default, which is an invalid 42 scope.

Co-authored-by: Alaa Zorkane <alaazorkane@gmail.com>
@github-actions github-actions bot added core Refers to `@auth/core` providers labels Nov 13, 2021
@balazsorban44
Copy link
Member

balazsorban44 commented Nov 13, 2021

Thank you! So you can confirm that this provider works in v4?

Would be nice to update the table in #2524 (comment)

Do you have some kind of picture as proof? Something that shows that the profile sets id, name, email and image correctly.

Take #2848 as an example of what I have in mind.

@estarossa0
Copy link
Contributor Author

Signing proof:

  • useSession output:
    image
  • signIn callback output:
    image

@balazsorban44
Copy link
Member

Thank you so much! 馃檹

@balazsorban44 balazsorban44 merged commit 38cefdd into nextauthjs:beta Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants