Fix: (Azure AD) Check for valid profile picture response before converting to base64 #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3656 +/- ##
==========================================
- Coverage 13.04% 13.01% -0.03%
==========================================
Files 92 92
Lines 1449 1452 +3
Branches 385 387 +2
==========================================
Hits 189 189
- Misses 1246 1249 +3
Partials 14 14
Continue to review full report at Codecov.
|
balazsorban44
requested changes
Jan 18, 2022
Co-authored-by: Balázs Orbán <info@balazsorban.com>
balazsorban44
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 💡
Currently, the
profile()function for Azure AD takes a response from the Microsoft Graph API and converts it to base64 for profile pictures. Unfortunately, this has caused bugs for my project because it doesn't make sure that the response from Microsoft is valid before converting. Users without a photo set on their account will not recieve a valid response, but an invalid "image" will still be returned.This PR adds a small check to the profile photo response to make sure the HTTP-status is 200-299. If the status is outside of that range, the profile image is left as an empty string.
Checklist 🧢
DocumentationTestsAffected issues 🎟
None