feat: added types for sign in errors #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
norbitrial
commented
Jan 25, 2022
balazsorban44
requested changes
Feb 1, 2022
There was a problem hiding this comment.
Thanks! Could we re-export this from next-auth?
Could you do the same for the error page as well?
next-auth/src/core/pages/error.tsx
Line 7 in 714d80a
balazsorban44
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 馃挕
This PR is intended to add typing for
<SigninPage />component'serrorproperty as the following:After this change it will accept only the giving
stringvalues. Originally it accepted anystringvalue.Checklist 馃Б
Affected issues 馃師
Fixes #3665