Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #929

Closed
balazsorban44 opened this issue Dec 7, 2020 · 3 comments · Fixed by #1011
Closed

Update CONTRIBUTING.md #929

balazsorban44 opened this issue Dec 7, 2020 · 3 comments · Fixed by #1011
Labels
documentation Relates to documentation enhancement New feature or request good first issue Good issue to take for first time contributors

Comments

@balazsorban44
Copy link
Member

balazsorban44 commented Dec 7, 2020 •
edited

We should update the CONTRIBUTING document to reflect the new structure, as soon as we have a clear method for automated releases. (#920 will probably solve this after some discussions)

I quickly added a PULL_REQUEST_TEMPLATE with a note that most PRs should be done against canary, but it is not a full solution as it contradicts the CONTRIBUTING.md at the moment.
@balazsorban44 balazsorban44 added enhancement New feature or request documentation Relates to documentation labels Dec 7, 2020
@balazsorban44
Copy link
Member Author

If someone would like to improve our PULL_REQUEST_TEMPLATE, please do!

@balazsorban44 balazsorban44 added the good first issue Good issue to take for first time contributors label Dec 10, 2020
@balazsorban44 balazsorban44 mentioned this issue Dec 30, 2020
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Jan 1, 2021

🎉 This issue has been resolved in version 3.2.0-canary.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This issue has been resolved in version 3.3.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Relates to documentation enhancement New feature or request good first issue Good issue to take for first time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update CONTRIBUTING.md nextauthjs/next-auth
1 participant
@balazsorban44