Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue-Rewrite? #301

Closed
jotoeri opened this issue Feb 23, 2021 · 3 comments · Fixed by #878
Closed

Vue-Rewrite? #301

jotoeri opened this issue Feb 23, 2021 · 3 comments · Fixed by #878
Labels
enhancement New feature or request
Milestone

Comments

@jotoeri
Copy link
Contributor

jotoeri commented Feb 23, 2021

I recently thought about implementing #300 just like the filePicker. But probably, and in combination with #1 it would be better to first rewrite the own library, before adding new stuff?
Maybe some nice task for the vue-expert @skjnldsv ? 🙈

@jotoeri jotoeri added the enhancement New feature or request label Feb 23, 2021
@skjnldsv
Copy link
Contributor

Well, this repo have a bit of everything.
The toast part, should definitely stay standalone as is, but writing a proper filepicker is definitely needed. There was some work iirc by @eneiluj. So I don't know what the status is so far :)

But having a proper filepicker here, in vue, is definitely needed! 🚀

@ChristophWurst
Copy link
Contributor

Yep, so basically what I wrote into #1 :D

@julien-nc
Copy link

@skjnldsv The file picker Vue component is released on NPM and used by a few projects AFAIK. I don't know if it fits in Nextcloud in its current state because it embeds all icons and includes some style adjustments. The translations are directly handled with gettext-parser.

But the FileBrowser sub component could be used in a component that would be designed to work in Nextcloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants