New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toastify dark mode regression #629

Closed

PVince81 opened this issue Jul 21, 2022 · 1 comment · Fixed by #630

Assignees

Contributor

PVince81 commented Jul 21, 2022 •

edited

we can't rely on a class set on the body and more: https://github.com/nextcloud/nextcloud-dialogs/blob/febaa367090498fcde5fe2b36f06a827de184089/styles/toast.scss#L110

need to detect it directly from the browser

PVince81 assigned nickvergessen

nickvergessen mentioned this issue

Fix dark mode with Nextcloud 25 #630

Merged

Contributor

nickvergessen commented Jul 21, 2022

need to detect it directly from the browser

Not exactly, because your browser can be dark mode but you force bright mode in the settings.

But fixed in #630

PVince81 closed this as completed in #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment