Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning about tag prop of router-link #3331

Closed
Chartman123 opened this issue Oct 2, 2022 · 1 comment · Fixed by #3775
Closed

Deprecation warning about tag prop of router-link #3331

Chartman123 opened this issue Oct 2, 2022 · 1 comment · Fixed by #3775
Labels
3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component feature: button feature: list-item Related to the list-item component technical debt

Comments

@Chartman123
Copy link
Contributor

I saw a deprecation warning in Forms stating [vue-router] <router-link>'s tag prop is deprecated and has been removed in Vue Router 4. Use the v-slot API to remove this warning.

https://next.router.vuejs.org/guide/migration/#removal-of-event-and-tag-props-in-router-link.

I think that this might originate from this part of the code:

https://github.com/nextcloud/nextcloud-vue/blob/ff44f28493c5505973bba3d44965dd0f9cfebe29/src/components/NcAppNavigationItem/NcAppNavigationItem.vue#L471-L483
@Chartman123 Chartman123 added feature: app-navigation Related to the app-navigation component 0. to triage labels Oct 2, 2022
@raimund-schluessler raimund-schluessler added 1. to develop Accepted and waiting to be taken care of technical debt and removed 0. to triage labels Feb 17, 2023
@raimund-schluessler raimund-schluessler linked a pull request Feb 25, 2023 that will close this issue
Migrate from router-link's tag prop to v-slot #3775
Merged
@raimund-schluessler
Copy link
Contributor

Fix is in #3775. Please test and review if possible.

@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: button feature: list-item Related to the list-item component and removed 1. to develop Accepted and waiting to be taken care of labels Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component feature: button feature: list-item Related to the list-item component technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from router-link's tag prop to v-slot nextcloud-libraries/nextcloud-vue
2 participants
@raimund-schluessler @Chartman123