Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar tabs design update #4034

Closed
2 tasks done
marcoambrosini opened this issue May 4, 2023 · 6 comments · Fixed by #4449
Closed
2 tasks done

Sidebar tabs design update #4034

marcoambrosini opened this issue May 4, 2023 · 6 comments · Fixed by #4449
Assignees
Labels
1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component

Comments

@marcoambrosini
Copy link
Contributor

marcoambrosini commented May 4, 2023

  • Remove border
  • Ellipse text instead of 2 lines

As discussed with @jancborchardt

@marcoambrosini marcoambrosini added the 1. to develop Accepted and waiting to be taken care of label May 4, 2023
@marcoambrosini marcoambrosini self-assigned this May 4, 2023
@ShGKme ShGKme added the feature: app-sidebar Related to the app-sidebar component label May 4, 2023
@dartcafe
Copy link
Contributor

dartcafe commented May 7, 2023

Does it address this "feature"?
grafik

@marcoambrosini
Copy link
Contributor Author

So I've been a bit reluctant with this because I think our current system doesn't work and we need to think this through a bit more. I think that we need to take a step back here and rethink how we do the sidebar altogether. I'm closing for now as this is just a cosmetic change that is not solving problems and in fact ellipsizing text on buttons is something that we've come to normalise but is just unacceptable.

Screenshot 2023-08-22 at 09 44 05

@jancborchardt
Copy link
Contributor

The ideal case would be that we just have 3 sidebar tabs:

  • Activity: All chronological info
  • Sharing
  • Details

Also ref nextcloud/server#658

And this issue here is precisely about the visual part, which should be fixed as well, not closed.
@marcoambrosini Stepping back to think about a perfect solution doesn't mean we have to leave the current state unwell. We need to work step by step on improving.

@marcoambrosini
Copy link
Contributor Author

I thought I was the only one that disliked the border so I figured I should leave it there as it doesn't really solve much. Implemented now.
Label trimming is already in.

@ShGKme
Copy link
Contributor

ShGKme commented Aug 24, 2023

@marcoambrosini what do you think about some multiline tabs design when text is not truncated? Taking into account that we have many apps with many tabs, many apps that adds more tabs (to files for example) and etc. Like very classic tabs, but with this pillow design

image

@marcoambrosini
Copy link
Contributor Author

@ShGKme That's one of the approaches I was thinking about, but visually they would look more like chips. I don't think it's the best approach though. I think the most viable solution is to remove the labels and have 44x44px buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants