Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--primary-element variable is not used throughtout components which leads to problems with theming #4070

Closed
szaimen opened this issue May 9, 2023 · 0 comments · Fixed by #4067
Closed

--primary-element variable is not used throughtout components which leads to problems with theming #4070

szaimen opened this issue May 9, 2023 · 0 comments · Fixed by #4067
Labels
2. developing Work in progress bug Something isn't working technical debt

Comments

@szaimen
Copy link
Contributor

szaimen commented May 9, 2023

you can use the following regex --color-primary(?!-element) to search for components that do not use the correct variable yet.

An attempt for some components is made in #4067.

Testing can be done with a very dark primary color in dark mode and the other way around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. developing Work in progress bug Something isn't working technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the color-primary-element* variables in components nextcloud-libraries/nextcloud-vue
1 participant
@szaimen