Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aria-label mandatory for buttons #4214

Open
ChristophWurst opened this issue Jun 14, 2023 · 1 comment
Open

Make aria-label mandatory for buttons #4214

ChristophWurst opened this issue Jun 14, 2023 · 1 comment
Labels
0. to triage accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: button

Comments

@ChristophWurst
Copy link
Contributor

We've logged a warning for a while

You need to fill either the text or the ariaLabel props in the button component

I think it would be fair to start enforcing this prop in a future major version.

Ref d441b9d @marcoambrosini
@ChristophWurst ChristophWurst added enhancement New feature or request accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: button 0. to triage labels Jun 14, 2023
@susnux
Copy link
Contributor

susnux commented Jun 27, 2023

From the discussion here it seems we should set the aria label always to the visual text and use a different attribute (title? aria-description?) for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: button
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristophWurst @susnux