Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcAppNavigationNew should be primary instead of secondary #4551

Closed
dartcafe opened this issue Sep 20, 2023 · 2 comments · Fixed by #4555
Closed

NcAppNavigationNew should be primary instead of secondary #4551

dartcafe opened this issue Sep 20, 2023 · 2 comments · Fixed by #4555
Labels
0. to triage design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component

Comments

@dartcafe
Copy link
Contributor

dartcafe commented Sep 20, 2023 •
edited

Nearly all apps use the type="primary" of the creation buttons inside the navigation, so NcAppNavigationNew should use primary too or at least support the type attribute of the NcButton component.
@dartcafe dartcafe mentioned this issue Sep 20, 2023
Closed
1 task
@dartcafe dartcafe changed the title NcAppNaviagtionNew should be primary instead of secondary NcAppNavigationNew should be primary instead of secondary Sep 20, 2023
@dartcafe dartcafe mentioned this issue Sep 21, 2023
Merged
3 tasks
@susnux
Copy link
Contributor

susnux commented Sep 26, 2023

CC design team @jancborchardt @marcoambrosini

@susnux susnux added design Design, UX, interface and interaction design 0. to triage feature: app-navigation Related to the app-navigation component labels Sep 26, 2023
@jancborchardt
Copy link
Contributor

Yep, the one main "+ New" button should always be primary. Also looking at the example from Polls which @dartcafe linked. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow type property for NcAppNavigationNew
3 participants
@jancborchardt @susnux @dartcafe