New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar headers are not visible enough #4785

Closed

nickvergessen opened this issue Nov 9, 2023 · 1 comment · Fixed by #4791

Labels

1. to develop accessibility feature: app-sidebar regression

Milestone

Contributor

nickvergessen commented Nov 9, 2023

Have a "dark" theming color and use dark mode

Expected

The sidebar is clearly visible

Actual

nickvergessen added 1. to develop regression feature: app-sidebar accessibility labels

nickvergessen added this to the 8.0.1 milestone

Contributor Author

nickvergessen commented Nov 9, 2023

Comments in the chat:

@nimishavijay

You are right, that color combination does not have enough contrast, the fallback colors should be triggered for such a dark color in dark mode. cc @marcoambrosini @szaimen
@susnux

I think we probably need to go the same way like with the button component which enforces primary style for checked state

nickvergessen mentioned this issue

fix(NcCheckboxRadioSwitch): Fix contrast of Radio switches using butt… #4791

Merged

2 tasks

nickvergessen closed this as completed in #4791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment