Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcActionButton should not leave uneeded space for icon if not provided #4939

Open
Fenn-CS opened this issue Dec 8, 2023 · 1 comment
Open

NcActionButton should not leave uneeded space for icon if not provided #4939

Fenn-CS opened this issue Dec 8, 2023 · 1 comment
Assignees
@Fenn-CS
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Dec 8, 2023

First mentioned in : nextcloud/server#41651
@Fenn-CS Fenn-CS added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of labels Dec 8, 2023
@Fenn-CS Fenn-CS self-assigned this Dec 8, 2023
@Fenn-CS Fenn-CS mentioned this issue Dec 8, 2023
Closed
10 tasks
@ShGKme
Copy link
Contributor

ShGKme commented Dec 8, 2023

Makes sense, but only if all the action buttons don't have an icon. If only some actions don't have an icon, they should still have the space to be inline with other buttons, as it works in desktop menus.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fenn-CS Fenn-CS

Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fenn-CS @ShGKme