Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change skin tone for emojis #5084

Closed
jancborchardt opened this issue Jan 17, 2024 · 2 comments · Fixed by #5103
Closed

Ability to change skin tone for emojis #5084

jancborchardt opened this issue Jan 17, 2024 · 2 comments · Fixed by #5103
Assignees
Labels
3. to review Waiting for reviews enhancement New feature or request feature: emoji picker Related to the emoji picker component
Milestone

Comments

@jancborchardt
Copy link
Contributor

Currently it is not possible to change the skin tone for emojis in the picker, it is always the yellow default.

The library we use actually allows for this and the design looks exactly like Twitter, it’s just something we have to enable again: https://serebrov.github.io/emoji-mart-vue/

@jancborchardt jancborchardt added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of feature: emoji picker Related to the emoji picker component labels Jan 17, 2024
@jancborchardt
Copy link
Contributor Author

jancborchardt commented Jan 17, 2024

The only question is how it will look like when opened. There are 2 states that I can see. It would be nice if we can use the left version with the simple "Pick your emoji" instead of the big EmojiMart branding.

Demo page linked above, looks nice "Custom dialog", with huge "EmojiMart" branding
image image

@jancborchardt
Copy link
Contributor Author

And additional point for Text, Collectives and Mail etc where the emoji picker is used by typing :, there the skin tone choice would need to be respected and remembered as well.

@susnux susnux self-assigned this Jan 22, 2024
@susnux susnux added this to the 8.5.0 milestone Jan 22, 2024
@susnux susnux added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: emoji picker Related to the emoji picker component
Projects
None yet
2 participants