Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filepicker/dialogs component #631

Closed
raimund-schluessler opened this issue Oct 5, 2019 · 7 comments · Fixed by #4550
Closed

Filepicker/dialogs component #631

raimund-schluessler opened this issue Oct 5, 2019 · 7 comments · Fixed by #4550
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion discussion Need advices, opinions or ideas on this topic

Comments

@raimund-schluessler
Copy link
Contributor

In #9 a filepicker component was mentioned as suggestion for a component, but I there is none yet afaik.

I think this would be a helpful improvement.

@raimund-schluessler raimund-schluessler added component Component discussion and/or suggestion discussion Need advices, opinions or ideas on this topic labels Oct 5, 2019
@skjnldsv
Copy link
Contributor

skjnldsv commented Oct 5, 2019

I think we should have one yes! :)
There was also a request for a npm library to allow picking files from other non nextcloud apps. Some kind of all-in-one nextcloud file picker :)

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Oct 5, 2019
@raimund-schluessler
Copy link
Contributor Author

There was also a request for a npm library to allow picking files from other non nextcloud apps. Some kind of all-in-one nextcloud file picker :)

Which other apps? And where would you use this? Could you give an example, please?

@skjnldsv
Copy link
Contributor

skjnldsv commented Oct 5, 2019

Well, it's not something for this library.
nextcloud/server#2028

It would be a library that allow you to somewhat authorise the integration of the picker from another website and pick a file. But that's irrelevant from here (only the design could be similar) and more importantly, faaaar from being on our roadmap ;)

Sorry for the annoyance! 🙈

@georgehrke
Copy link
Contributor

There is a file picker in nextcloud/dialogs: https://github.com/nextcloud/nextcloud-dialogs/blob/master/lib/filepicker.ts

@raimund-schluessler
Copy link
Contributor Author

I am fine with the filepicker in nextcloud/dialogs. Should we close this here then?

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 20, 2020

No, because we should improve things.
I discussed this wit Christoph a few weeks ago.

We should create a Dialog component here.
But we should also create a proper way to call a standalone component in dialogs (file picker, password input, prompt & confirm),to replace what we currently have in server.
The same way we call the Toasts. showDialogPrompt(...), showFilePicker(...)... etc etc

So component here, shorthands and easy accessible functions in dialogs :)

@skjnldsv skjnldsv changed the title Filepicker component Filepicker/dialogs component Apr 29, 2020
@Spartachetto
Copy link

Spartachetto commented Jun 11, 2020

I had some issues with the current filepicker. I'll put them here, also because @georgehrke is contributing to this issue. Please tell me if this is the wrong place.

Nextcloud version: 18.0.3
Contacts verion: 3.3.0

I was trying to add a photo to a contact. I opened the contact, clicked on the circle on the left of the name and selected the option to choose a file already uploaded in my Nextcloud instance.

Here are the two problems:

  1. I cannot select the file by tag. I try to tag my photos, the photos I have of that person were tagged. Yet I had to go back to the File app to have the possibility to search by tag
  2. Once I knew which was the right photo, I went back to the contact app, did the same passages and opened the filepicker. The names of the files are ellipsized.... This means that if you have a folder with photos of the same days with name format like yyyymmdd_hhmmss, all you can see is something like yyyymm....mmss. That means that picking the right photo is difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion discussion Need advices, opinions or ideas on this topic
Projects
None yet
4 participants