Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiselect placeholder needs left padding when not focussed #66

Closed
ChristophWurst opened this issue Oct 15, 2018 · 5 comments
Closed

Multiselect placeholder needs left padding when not focussed #66

ChristophWurst opened this issue Oct 15, 2018 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: select Related to the NcSelect* components

Comments

@ChristophWurst
Copy link
Contributor

As discovered in nextcloud/server#11765 (comment).
@ChristophWurst ChristophWurst added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Oct 15, 2018
@ChristophWurst
Copy link
Contributor Author

@MorrisJobke what browser did you test this with? On FF and Chrome this looks fine here.

@skjnldsv
Copy link
Contributor

@ChristophWurst make sure this is not a conflict of scoped. Theoritecally .multiselect on nextcloud referes to another library we used on jQuery. You need the vue-multiselect class to force apply the theme to the vue-multiselect component. Once our package is scoped we won't need it anymore :)
https://github.com/nextcloud/contacts/blob/226e44d7a612cd3a4d5ed0f025e50caebfb7858b/src/components/Settings/SettingsImportContacts.vue#L36

@skjnldsv skjnldsv added the feature: select Related to the NcSelect* components label Oct 15, 2018
@MorrisJobke
Copy link
Contributor

@MorrisJobke what browser did you test this with? On FF and Chrome this looks fine here.

Safari

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 9, 2018

Coming from: https://github.com/shentao/vue-multiselect/blob/28dd68a7c4b4e34346a5ede79fdc328727136dc7/src/Multiselect.vue#L330

@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 8, 2019

Fixed in 02727e9

@skjnldsv skjnldsv closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MorrisJobke @ChristophWurst @skjnldsv