Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Adapt visual "Your activities" <h1> which remains the same through all activities pages #1464

Closed
JuliaKirschenheuter opened this issue Dec 15, 2023 · 5 comments · Fixed by #1512

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Dec 15, 2023

"your activities" is always visible as <h1>. Some time ago i've implemented visually hidden <h1> to be relied on the section in a sidebar: #1081

@nickvergessen is it a bug or a feature?

@nickvergessen
Copy link
Member

I'm not up to date with the recent changes the app is going through in the frontend,
but looks intentional:
https://github.com/nextcloud/activity/blame/2accba255dcd732bf08bdfe51efbd087b49b7af8/src/views/ActivityAppFeed.vue#L24

@susnux
Copy link
Contributor

susnux commented Jan 9, 2024

This was decided by designers also for photos and logreader

@JuliaKirschenheuter
Copy link
Contributor Author

Dear designers,

In our other apps like Files, Photos <h1> visual heading (or hidden heading) changes are based on a section in left navigation (like "Shared with you", "Collaborative albums"). This is also important for a11y. Could we adapt it for Activity too? Then we would have instead of "Your activities" -> "By others".

@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV]: Remove visual "Your activities" <h1> which remains through all activities pages [BITV]: Adapt visual "Your activities" <h1> which remains the same through all activities pages Jan 12, 2024
@jancborchardt
Copy link
Member

Seems like a duplicate of this issue I reported 1 day before this one? :D
#1463

And as far as I understand @JuliaKirschenheuter I agree with your take?

@JuliaKirschenheuter
Copy link
Contributor Author

Thank you @jancborchardt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants