Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Handling #14

Closed
4 tasks done
David-Development opened this issue Jun 14, 2018 · 3 comments
Closed
4 tasks done

Error Handling #14

David-Development opened this issue Jun 14, 2018 · 3 comments

Comments

@David-Development
Copy link
Member

David-Development commented Jun 14, 2018 •
edited
Loading

I can think we need to catch/handle the following "error" cases within this library.

  • User requests account (nextcloud app is not installed)
  • Account has been deleted from Android
  • Account has been modified (do we need to know that?) (do we care?)
  • Incompatible app versions
@David-Development
Copy link
Member Author

@tobiasKaminsky fyi: I'm working on this right now

@tobiasKaminsky
Copy link
Member

👍

  1. according to your flow chart, this is already there?
  2. yes, this indeed should be handled correctly
  3. the 3rd party app is only storing the account name and a token to verify. Those values are not allowed to be changed. If on server side the password is changed, the 3rd party app does not need to care as this is handled by files app.

@David-Development David-Development mentioned this issue Jun 14, 2018
Closed
@David-Development
Copy link
Member Author

Exception handling for case 1-3 was added in 70831be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@David-Development @tobiasKaminsky