Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gson as dependency of sso library #67

Closed
David-Development opened this issue Jul 20, 2019 · 3 comments
Closed

add gson as dependency of sso library #67

David-Development opened this issue Jul 20, 2019 · 3 comments

Comments

@David-Development
Copy link
Member

TODO: also remove import of gson from README after adding gson as a dependency to sso.

@burningthumb
Copy link
Contributor

So maybe there is something I don't understand. I still need to include the dependency:

implementation 'com.google.code.gson:gson:2.8.5

In my libraries build.gradle file.

In fact I took a closer look at the original build.gradle file for the sso library and I see it already did include this dependency (now its in there twice - sorry I did not notice it the first time).

Any ideas ?

@Unpublished
Copy link
Contributor

You can try to change implementation 'com.google.code.gson:gson:2.8.5 to api 'com.google.code.gson:gson:2.8.5 in SSO.

It should include the gson library transitively.

@burningthumb
Copy link
Contributor

Yes I think that is the solution since I am using the SSO library from another library it needs to be api instead implementation. I've made the change and will add a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants