Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App allows to go out of ../emulated , but not to come back #3449

Closed
telmich opened this issue Jan 13, 2019 · 13 comments
Closed

App allows to go out of ../emulated , but not to come back #3449

telmich opened this issue Jan 13, 2019 · 13 comments

Comments

@telmich
Copy link

telmich commented Jan 13, 2019

When selecting files, it is possible to go to /. However once being there, it shows no files found and you cannot go back in the tree anymore

@nextcloud-android-bot

This comment has been minimized.

@tobiasKaminsky
Copy link
Member

Maybe we should check if we have read permission on the upper/parent folder and only then allow going to it.

@AndyScherzinger
Copy link
Member

Well, We probably should have a chooser for the storage paths like sd-card, internal, etc. (e.g. like Amaze File Manager), no?

@DecaTec
Copy link

DecaTec commented Jan 14, 2019

Maybe also related to #3419

@AndyScherzinger
Copy link
Member

Good catch @DecaTec - they probably share the exact same root cause, yes.

@tobiasKaminsky
Copy link
Member

Well, We probably should have a chooser for the storage paths like sd-card, internal, etc. (e.g. like Amaze File Manager), no?

This seems to be the only possible solution, as e.g. on emulator:
/storage/emulated/0/ is internal storage
/storage/0EF5-160/ is sdcard
/storage/emulated/ is permission denied

So going from /storage/emulated/0/ to /storage/ to /storage/0EF5-160/ works, but then you can never get back to internal storage.

Maybe we should check if we have read permission on the upper/parent folder and only then allow going to it.

This will therefore do not work, as then we would be locked in /storage/emulated/0/

@AndyScherzinger do you have an idea where/how this chooser should look like?

@AndyScherzinger
Copy link
Member

Good question, we can't use the drawer menu like Amaze but we could use the chooser in the toolbar for that and drop its current functionality?

@tobiasKaminsky
Copy link
Member

Hm. Actually I do like the hierarchically view of folders, as you can then jump easily 2-3 folders up. This would also be nice to have in the regular file listing, in my opinion.

We could have some sort of button that opens a dialog with these "special" folders, also like Camera, etc.
But this feels a bit out of place then…

@AndyScherzinger
Copy link
Member

Where would you put this button, also calling @nextcloud/designers for feedback :)

@tobiasKaminsky
Copy link
Member

No real idea…on header next to overflow menu?

@AndyScherzinger
Copy link
Member

No real idea…on header next to overflow menu?

Thant would work and likely be the easiest way to implement it (technically speaking)

@jancborchardt
Copy link
Member

jancborchardt commented Feb 11, 2019

Well, We probably should have a chooser for the storage paths like sd-card, internal, etc. (e.g. like Amaze File Manager), no?

Yeees please. :D All this /0/emulated is soo confusing. ;)

Couldn’t this be the very top level, with a listing of "Storage" and "SD card"? If there is only one storage, the view is not needed and the last readable root is "Storage".

@tobiasKaminsky
Copy link
Member

Hm, I currently have no clue where and how this listing should look like.
Can you explain this a bit more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants