Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload list action icon for failed/pending uploads #3618

Open
jancborchardt opened this issue Feb 13, 2019 · 8 comments
Open

Upload list action icon for failed/pending uploads #3618

jancborchardt opened this issue Feb 13, 2019 · 8 comments
Labels
design enhancement feature: sync and upload Syncing or uploading (that isn't auto upload specific)

Comments

@jancborchardt
Copy link
Member

Follow-up to #3472

After looking at it again I had the initial confusion of "But how do I retry a failed upload?" since only the delete action is so present.

We should instead have a 3-dot icon which includes both "Retry" and "Cancel" (and cancel using the x icon, not delete as it does not delete a file).

2019-02-07-093735

@nextcloud-android-bot

This comment has been minimized.

@AndyScherzinger
Copy link
Member

Well, the delete action (trashbin) is actually also just a cancel so. Shouldn't that also be the x-icon?
As for the menu, we can add a menu while Android menus don't have icons.

@jancborchardt
Copy link
Member Author

As for the menu, we can add a menu while Android menus don't have icons.

Right, that’s fine. :)

Well, the delete action (trashbin) is actually also just a cancel so. Shouldn't that also be the x-icon?

What do you mean by that? Deleting a file? That’s not just removing an entry/notification, but an actual file. :)

@AndyScherzinger
Copy link
Member

Not in the upload list... The it "deletes" the entry afaik. Cc @tobiasKaminsky

@jancborchardt
Copy link
Member Author

I think we are talking about the same thing then and agree. :) What I mean is that in the above screenshot, the icon which is a trashbin should instead be an X. Because it only removes an entry in this upload list but does not delete an actual file.

@AndyScherzinger
Copy link
Member

❤️ Yes, that's what we both meant 👍

@AndyScherzinger
Copy link
Member

Btw the clear all failed option is in the toolbar's menu atm which we would then remove (only menu entry atm). This can be tested in the current dev build.

@tobiasKaminsky
Copy link
Member

Nice improvement idea!

@joshtrichards joshtrichards added the feature: sync and upload Syncing or uploading (that isn't auto upload specific) label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement feature: sync and upload Syncing or uploading (that isn't auto upload specific)
Projects
None yet
Development

No branches or pull requests

5 participants