Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process of choosing accounts when uploading from another app #6117

Open
szaimen opened this issue May 20, 2020 · 12 comments
Open

Process of choosing accounts when uploading from another app #6117

szaimen opened this issue May 20, 2020 · 12 comments

Comments

@szaimen
Copy link
Contributor

szaimen commented May 20, 2020

Is your feature request related to a problem? Please describe.

When I try to upload a file from another app to my Nextcloud with the Nextcloud app, I am presented directly with a folder picker from the current user.

Describe the solution you'd like

Would be nice, if it could show an account chooser directly if more than one account is logged into the app, so that I don't have to press on the 3 dots on the top right and click on switch user before I can choose the folder when sharing a file from another app to upload it, if the active user is the false one.

Additional context

Maybe the account chooser could be based on #6116?

Thanks!

@Kilian-Perisset

This comment has been minimized.

@szaimen
Copy link
Contributor Author

szaimen commented May 20, 2020

Oh, didn't see that.

Would it be possible to present this account chooser directly when entering the app while sharing a file to the app wihtout having to click on the 3 dots and choose an account?

I think that would make sense from a UX perspective.

@Kilian-Perisset
Copy link
Member

Unfortunately, I don't decide how Nextcloud and its functionalities are arranged.
My advice is to rename your issue accordingly, and explain what you want, and then ask @jancborchardt :)

@szaimen szaimen changed the title Make it possible to choose the account when sharing a file from another app to upload it Present an account chooser dirsctly when sharing a file from another app to upload it May 20, 2020
@szaimen
Copy link
Contributor Author

szaimen commented May 20, 2020

Unfortunately, I don't decide how Nextcloud and its functionalities are arranged.
My advice is to rename your issue accordingly, and explain what you want, and then ask @jancborchardt :)

I did that, thanks for the advice!
Hopefully @jancborchardt responds...

@szaimen szaimen changed the title Present an account chooser dirsctly when sharing a file from another app to upload it Present an account chooser directly when sharing a file from another app to upload it May 20, 2020
@jancborchardt
Copy link
Member

Would it be possible to present this account chooser directly when entering the app while sharing a file to the app wihtout having to click on the 3 dots and choose an account?

We used to have it like that, with the account chooser always shown. It was very annoying, for example in setups where you have 2 accounts, one personal and one for work, and you almost never upload stuff into your work one but still always need to choose.

So opening the account switcher by default on uploading from another app is something we will not do again.

We could make the switcher more obvious, or for example also make the header text clickable where the handle is shown?

@jancborchardt jancborchardt changed the title Present an account chooser directly when sharing a file from another app to upload it Process of choosing accounts when uploading from another app May 20, 2020
@szaimen
Copy link
Contributor Author

szaimen commented May 20, 2020

@jancborchardt Okay, I can understand that.

Than what about showing the account picture of the current account in the root directory, showing the account name and not their mailaddress and imo the search button isn't really needed here. I would put it into the 3-dot menu.

That would at least improve the account identification based on a profile photo and the correct username instead of only the mailaddress...

Currently Proposed
image image
image image

@szaimen
Copy link
Contributor Author

szaimen commented May 20, 2020

BTW: to make that complete the upload folder picker shouldn't remember the folder where the last upload was uploaded to but instead always open in the root directory...

@jancborchardt
Copy link
Member

jancborchardt commented May 20, 2020

Than what about showing the account picture of the current account in the root directory
and imo the search button isn't really needed here. I would put it into the 3-dot menu.

Because we remember the last folder, you might not always start in the root folder.
We could show the avatar/chooser in all directories but on the right, for multiple accounts instead of the search icon. Search could then go into the 3-dot-menu as you said.

showing the account name and not their mailaddress

It's not the mailaddress but username@cloudaddress.com, which we show because it is unique. The real name of a person is likely the same on all their accounts, so that would lead to confusion and make the subline useless.

@szaimen
Copy link
Contributor Author

szaimen commented May 20, 2020

Than what about showing the account picture of the current account in the root directory
and imo the search button isn't really needed here. I would put it into the 3-dot menu.

Because we remember the last folder, you might not always start in the root folder.
We could show the avatar/chooser in all directories but on the right, for multiple accounts instead of the search icon. Search could then go into the 3-dot-menu as you said.

That sounds like the best solution.
But why not on the left side? understood it: because of the back arrow
@jancborchardt Would you make a mockup or shall I try to make one myself?

showing the account name and not their mailaddress

It's not the mailaddress but username@cloudaddress.com, which we show because it is unique. The real name of a person is likely the same on all their accounts, so that would lead to confusion and make the subline useless.

Oh, haven't seen that. Probably makes sense 👍

@szaimen
Copy link
Contributor Author

szaimen commented May 20, 2020

showing the account name and not their mailaddress

It's not the mailaddress but username@cloudaddress.com, which we show because it is unique. The real name of a person is likely the same on all their accounts, so that would lead to confusion and make the subline useless.

Oh, haven't seen that. Probably makes sense 👍

I have an idea how that could be solved differently:
maybe you could check the usernames of logged in nextcloud accounts and if all are different, then just display the username in this activity and if at least two usernames are the same, only then display the federation id?

@jancborchardt
Copy link
Member

I have an idea how that could be solved differently:
maybe you could check the usernames of logged in nextcloud accounts and if all are different, then just display the username in this activity and if at least two usernames are the same, only then display the federation id?

That’s way too complicated and inconsistent. It should always be the handle, as otherwise there could still be confusion as to which account is used.

@szaimen
Copy link
Contributor Author

szaimen commented May 21, 2020

I have an idea how that could be solved differently:
maybe you could check the usernames of logged in nextcloud accounts and if all are different, then just display the username in this activity and if at least two usernames are the same, only then display the federation id?

That’s way too complicated and inconsistent. It should always be the handle, as otherwise there could still be confusion as to which account is used.

Hm, I guess you haven't completely understood what I meant:
here a better explanation:

example1: two users are logged into the app:

  1. account_id="max@example.com", username="Max Mustermann"
  2. account_id="max@another.example.com", username="Max Mustermann"

in this case, I would dispay the account_id because the username of account 1 and 2 are the same
(so there are two usernames that match; if a different username was added, this would still be the case)

example2: again two users are logged into the app:

  1. account_id="max@example.com", username="Max Mustermann"
  2. account_id="admin.max@another.example.com", username="Admin Max"

in this case, I would display the username because all usernames are different.
(as long as an additional username isn't called "Max Mustermann" or Admin Max")

So there should be no confusion because in example2 you show always the username.
And in example1 you show always the accound_id.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants