Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter library import #693

Closed
mario opened this issue Feb 28, 2017 · 4 comments
Closed

Adapter library import #693

mario opened this issue Feb 28, 2017 · 4 comments

Comments

@mario
Copy link
Contributor

mario commented Feb 28, 2017

I would like to ask if I can import the following library:

https://github.com/davideas/FlexibleAdapter

It would be good so we can use sticky headers, load more, animations and such without reinventing the wheel.

Thanks!

cc @AndyScherzinger @tobiasKaminsky

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 2, 2017

Following up on the discussion on IRC, I vote yes for several reasons:

  • the idea is to start integrating it with 2.1 and until then the 5.0 release (of the lib) should be released stable
  • it can then replace the SectionedRecyclerViewAdapter lib we use for the auto upload view
  • we can make use of load more (for activities), sticky list headers (upload view, sorting orders, etc.)
    *`according to the lib description also safe on some boilerplate code (haven't looked at that in detail yet).

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Mar 4, 2017

Fine for me 👍
But should be done step by step and not in one big huge PR as this is too hard to review.
So, eg. one PR for auto upload view, one for sticky list header on upload view, and so on.

Best would be to brainstorm what we want to change as a meta issue and then to this step by step like in #285

@joshtrichards
Copy link
Member

This library is now de facto defunct: davideas/FlexibleAdapter#773 (comment)

@tobiasKaminsky
Copy link
Member

Thus closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants