Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide event details properties info buttons when event in read-only mode #1585

Closed
tcitworld opened this issue Oct 26, 2019 · 2 comments · Fixed by #1595
Closed

Hide event details properties info buttons when event in read-only mode #1585

tcitworld opened this issue Oct 26, 2019 · 2 comments · Fixed by #1595
Labels
3. to review Waiting for reviews Feature: Editor
Milestone
2.0.0 beta2

Comments

@tcitworld
Copy link
Member

It feels strange and is probably not needed since values are already present.

Also tooltips are bad UX on mobile, but that's another topic.

What do you think @georgehrke @jancborchardt?
@tcitworld tcitworld added 1. to develop Accepted and waiting to be taken care of enhancement-proposed Feature: Editor labels Oct 26, 2019
@tcitworld tcitworld added this to the 2.0.0 beta3 milestone Oct 26, 2019
@jancborchardt
Copy link
Member

Right, also the "All day" checkbox is redundant when it’s not editable.

@georgehrke
Copy link
Member

also the "All day" checkbox is redundant when it’s not editable.

Opened a dedicated issue for it #1589

@georgehrke georgehrke mentioned this issue Oct 26, 2019
Merged
@georgehrke georgehrke modified the milestones: 2.0.0 beta3, 2.0.0 beta2 Oct 26, 2019
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews Feature: Editor
Projects
None yet
Milestone
2.0.0 beta2
Development

Successfully merging a pull request may close this issue.

Hide property info in read-only mode nextcloud/calendar
3 participants
@jancborchardt @georgehrke @tcitworld